Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merge Nexus into Master #2270

Merged
merged 17 commits into from
Oct 15, 2024
Merged

Merge Nexus into Master #2270

merged 17 commits into from
Oct 15, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Oct 15, 2024 •
edited
Loading

Merge Nexus into Master. All of these individual commits have been reviewed by at least one SDK team member.

Before this PR is merged I would like to merge #2269 and #2266 into nexus first.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner October 15, 2024 18:17
cretz
cretz approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming:

  1. All this code was reviewed in other PRs before it hit the nexus branch
  2. All Nexus things are marked experimental
  3. Only Nexus users are affected (meaning if you aren't using Nexus, no behavior has changed in any way for you)

@Quinn-With-Two-Ns
Nexus Java SDK Workflow API (#2211)
300c8dc 
Add Nexus Workflow API
@Quinn-With-Two-Ns
Nexus worker support (#2214)
4af66af 
Nexus worker support
@Quinn-With-Two-Ns
Nexus java SDK workflow operations (#2231)
181e9a7 
Nexus workflow operation support
@Quinn-With-Two-Ns
Add Nexus support to TestWorkflowExtension (#2238)
75b1ff0 
Add Nexus support to TestWorkflowExtension
@Quinn-With-Two-Ns
Add helper for Nexus to Kotlin Integration (#2230)
5103bbb 
Add helper for Nexus to Kotlin
@Quinn-With-Two-Ns
Add support for auto discovery of Nexus Services (#2239)
b7f9e7b 
Springboot auto discovery support for NexusServices
@Quinn-With-Two-Ns
Nexus: Well know error translation (#2242)
bf97836 
Add conversion for common errors
@Quinn-With-Two-Ns
Add terminate workflow test (#2252)
f8ba5e3 
Add terminate workflow test
@Quinn-With-Two-Ns
Fix UpdateWithStartTest
463391a
@Quinn-With-Two-Ns
Add cancel async operation tests (#2250)
c219d57 
Add cancel async operation tests
@Quinn-With-Two-Ns
Include failure message in Nexus exception (#2251)
da82f67
@Quinn-With-Two-Ns
Add note on SerializationContext for Nexus (#2255)
5bbb69f
@Quinn-With-Two-Ns
Add some nexus option validation (#2260)
658fb3d 
Add some nexus option validation
@Quinn-With-Two-Ns
Change when nexus_task_execution_failed is emitted (#2261)
9ca0b7d
@Quinn-With-Two-Ns
Improve nexus operation failure handling (#2267)
1d2e250
@Quinn-With-Two-Ns
Add Nexus operation link support (#2266)
071fc2e 
Add Nexus operation link support
@Quinn-With-Two-Ns
mark the nexus sdk as an api dep. (#2269)
932073d
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit eff3ca2 into master Oct 15, 2024
11 checks passed
@Quinn-With-Two-Ns Quinn-With-Two-Ns deleted the nexus branch October 15, 2024 19:26
@cretz cretz mentioned this pull request Mar 11, 2025
Open
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cretz cretz cretz approved these changes

@bergundy bergundy Awaiting requested review from bergundy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz