Add failure_reason to nexus_task_execution_failed #2274

Quinn-With-Two-Ns · 2024-10-16T15:53:05Z

Add failure_reason to nexus_task_execution_failed based on the Go SDK PR temporalio/sdk-go#1671

cretz · 2024-10-16T17:27:02Z

Would like to get confirm the expected enumerates on the other PR before merging this one.

Quinn-With-Two-Ns · 2024-10-18T16:06:18Z

@cretz good to merge now that Go is merged?

cretz

LGTM. I have been told by @bergundy that it's handler_error_<TYPE> where TYPE is SCREAMING_SNAKE_CASE, so I assume the same here.

Quinn-With-Two-Ns · 2024-10-23T23:22:09Z

temporal-sdk/src/test/java/io/temporal/workflow/nexus/OperationFailMetricTest.java

+import org.junit.Rule;
+import org.junit.Test;
+
+public class OperationFailMetricTest {


@cretz these tests should hopefully assert parity between the Go and Java SDK

Quinn-With-Two-Ns requested a review from a team as a code owner October 16, 2024 15:53

Quinn-With-Two-Ns force-pushed the issue-2273 branch from 74342b9 to 588492b Compare October 16, 2024 17:18

Quinn-With-Two-Ns force-pushed the issue-2273 branch from 588492b to 65be4ec Compare October 18, 2024 16:06

cretz approved these changes Oct 18, 2024

View reviewed changes

Quinn-With-Two-Ns force-pushed the issue-2273 branch from 65be4ec to 7caa3dc Compare October 23, 2024 23:18

Quinn-With-Two-Ns requested a review from cretz October 23, 2024 23:21

Quinn-With-Two-Ns commented Oct 23, 2024

View reviewed changes

cretz approved these changes Oct 24, 2024

View reviewed changes

Quinn-With-Two-Ns added 3 commits October 24, 2024 07:56

Add failure_reason to nexus_task_execution_failed

cc9b179

Metric test

9ad4727

Fix timeout case

372f707

Quinn-With-Two-Ns force-pushed the issue-2273 branch from 7caa3dc to 372f707 Compare October 24, 2024 14:56

Quinn-With-Two-Ns merged commit 27d998a into temporalio:master Oct 24, 2024
8 checks passed

Provide feedback