Make headers in ExecuteNexusOperationInput case insensitive #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Dec 4, 2024
| (k) -> k.getKey().toLowerCase(), | ||
| Map.Entry::getValue, | ||
| (a, b) -> a, | ||
| () -> new TreeMap<>(String.CASE_INSENSITIVE_ORDER))); |
There was a problem hiding this comment.
A nice bonus of having a deterministically sorted map too
Quinn-With-Two-Ns
force-pushed
the
ExecuteNexusOperationInput-case-insentive-headers
branch
from
7e50163 to
1797d52
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make headers in ExecuteNexusOperationInput case insensitive, this will align with other Nexus headers that are all case insensitive.