Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

💥 Nexus error rehydration #2365

Merged
merged 8 commits into from
Feb 20, 2025
Merged

💥 Nexus error rehydration #2365

merged 8 commits into from
Feb 20, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Jan 13, 2025 •
edited
Loading

Nexus error rehydration and update Nexus SDK to v0.4.0-alpha

Breaking changes include:

  • Renaming for Nexus SDK
  • Changing the return type of the failure converter

bergundy
bergundy approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly reviewed the conversion logic and test cases.

@Quinn-With-Two-Ns Quinn-With-Two-Ns changed the title Nexus error rehydration 💥 Nexus error rehydration Feb 19, 2025
@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review February 19, 2025 23:11
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 19, 2025 23:11
cretz
cretz approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM knowing we'll make the return-type change clear in release notes

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit f92b53c into temporalio:master Feb 20, 2025
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quinn-With-Two-Ns @bergundy @cretz