Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inject namespace header #2400

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Inject Namespace in grpc headers. Unfortunately I couldn't use gRPC interceptors as originally proposed because java's gRPC interceptors cannot modify the header based of the content of the message grpc/grpc-java#4684 (comment)

closes #2058

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a separate issue, we should consider a test with cloud data plane and API key to confirm this works there, but I may open some separate issues on that.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit fd65ea9 into temporalio:master Feb 4, 2025
8 checks passed
@nzuguem
Copy link

nzuguem commented Mar 9, 2025

Since release v1.28.0, I've had a problem (io.grpc.StatusRuntimeException: PERMISSION_DENIED: Request unauthorized) with authentication via API Key to Temporal Cloud. After investigation (via git bisect) I can see that it's this PR that's causing the problem.

I may create a separate issue

@Quinn-With-Two-Ns
Copy link
Contributor Author

@nzuguem for issues connecting to Temporal cloud please use reach out to support to create a ticket

@nzuguem
Copy link

nzuguem commented Mar 10, 2025

Thanks for your answer. I'm going to create a ticket for Temporal Cloud.

I'd like to remind you that this worked normally with SDK v1.27.1, but since v1.28.0 with the addition of interceptors in this PR, it no longer works. I've even tried removing the interceptors I added manually, but it still doesn't work.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Temporal-Namespace header on every namespace-specific gRPC request
3 participants