Skip to content

Commit

Permalink
Add requirement to comment listing requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
dandavison committed Dec 5, 2023
1 parent 0477861 commit 26c2e9d
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions packages/workflow/src/internals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -565,23 +565,25 @@ export class Activator implements ActivationHandler {
// The implementation below is responsible for upholding, and constrained
// by, the following contract:
//
// 1. During validation, any error must fail the Update; during the Update
// 1. If no validator is present then validation interceptors will not be run.
//
// 2. During validation, any error must fail the Update; during the Update
// itself, Temporal errors fail the Update whereas other errors fail the
// activation.
//
// 2. The handler must not see any mutations of the arguments made by the
// 3. The handler must not see any mutations of the arguments made by the
// validator.
//
// 3. Any error when decoding/deserializing input must be caught and result
// 4. Any error when decoding/deserializing input must be caught and result
// in rejection of the Update before it is accepted, even if there is no
// validator.
//
// 4. The initial synchronous portion of the (async) Update handler should
// 5. The initial synchronous portion of the (async) Update handler should
// be executed after the (sync) validator completes such that there is
// minimal opportunity for a different concurrent task to be scheduled
// between them.
//
// 5. The stack trace view provided in the Temporal UI must not be polluted
// 6. The stack trace view provided in the Temporal UI must not be polluted
// by promises that do not derive from user code. This implies that
// async/await syntax may not be used.
//
Expand Down

0 comments on commit 26c2e9d

Please # to comment.