feat(client): Add startDelay to workflow (signal) start options #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
reviewed
Nov 21, 2023
dandavison
reviewed
Nov 21, 2023
dandavison
reviewed
Nov 21, 2023
dandavison
reviewed
Nov 21, 2023
dandavison
previously requested changes
Nov 21, 2023
antlai-temporal
dismissed
dandavison’s stale review
I think they have been taken care by the other changes, let me know otherwise...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The Temporal server introduced the ability to delay the start of a workflow using the attribute
startDelayin version 1.21.This PR enables it for the TypeScript SDK.
There are also some format changes to Rust files in
core-bridgeafter usingnpm run format. They were missing in previous commits because npm run lint.check does not validate Rust files withcargo fmt.[Feature Request][TS] Expose
StartWorkflowOptions.workflowStartDelay#1262Two system tests added