Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix comment typo on how default maxConcurrentActivityTaskPolls is calculated #1374

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

taonic
Copy link
Contributor

@taonic taonic commented Mar 15, 2024

What was changed

Fix a typo in comment.

Why?

So it's consistent with the actual code.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@taonic taonic requested a review from a team as a code owner March 15, 2024 03:34
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I’m wondering if the defaults are right though. I think Go has a much lower default.

@mjameswh

@mjameswh
Copy link
Contributor

mjameswh commented Mar 18, 2024

I’m wondering if the defaults are right though. I think Go has a much lower default.

There are very few cases where 10 pollers will be "too much" (to the point of causing side effects), but there are lots of cases where less than 10 would not be enough to keep the activity task execution slots filled…

Or put another way, if we set the default lower than 10, then most users should increase that value in their prod settings, where now, most people just ignore it.

@mjameswh mjameswh merged commit 4d76aa4 into main Mar 26, 2024
28 of 29 checks passed
@mjameswh mjameswh deleted the taonic/update_poller_inline_doc branch March 26, 2024 16:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants