-
Notifications
You must be signed in to change notification settings - Fork 122
Instrument signals with OTel #1449
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Instrument signals with OTel #1449
Conversation
Thanks @iravid for sharing this. There's a few things that needs to happen before we can merge this:
Also, if you feel up to the task, we should do the same with |
Thanks @mjameswh! Will happily address those two; thanks for the pointer to the tests. I'm a bit short on time this week so if alright by you will save instrumentation of the other operations for another PR? |
Sure, no problem. |
Hey @mjameswh apologies for the delay here (😅) - added the requested adjustments and tested locally by removing the |
Hi @mjameswh - any chance you could have a look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Thanks a lot for adding tests, @iravid, and sorry for the delays!
What was changed
Add instrumentation to
signal
in the client interceptor andhandleSignal
in the workflow inbound interceptor.Why?
We're starting activities from signal handlers and would like to see them on the same trace.
Checklist
Haven't seen tests in this module - lmk if needed! Will test this soon on our own project.
Don't think so!