Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(workflow): Unify GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update #1452

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat(workflow): Unify GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update #1452

merged 1 commit into from
Jun 28, 2024

Conversation

antlai-temporal
Copy link
Contributor

What was changed

Introduced a new exception WorkflowUpdateRPCTimeoutOrCancelledError that unifies grpc exceptions DEADLINE_EXCEEDED and CANCELLED during an update call for starting or polling for a result.

Checklist

  1. Closes
    Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update #1422
  2. How was this tested:
    Integration tests

@antlai-temporal antlai-temporal requested a review from a team as a code owner June 27, 2024 18:40
mjameswh
mjameswh approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antlai-temporal antlai-temporal merged commit c69795d into temporalio:main Jun 28, 2024
69 of 70 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mjameswh mjameswh mjameswh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antlai-temporal @mjameswh