Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(doc): Docs were no longer being built and deployed in CI #1494

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

mjameswh
Copy link
Contributor

What was changed

  • Don't use lerna to run the maybe-install-deps-and-build-docs task as packages/docs is no longer considered a workspace package.
  • There was apparently a LF character at the end of the IS_MAIN_OR_RELEASE env variable, preventing the env.IS_MAIN_OR_RELEASE == 'true' condition to evaluates to true, which in turn prevented deployment of docs to vercel.

@mjameswh mjameswh requested a review from a team as a code owner August 14, 2024 07:15
@mjameswh mjameswh merged commit 56207d8 into temporalio:main Aug 14, 2024
65 of 70 checks passed
@mjameswh mjameswh deleted the deploy-docs branch August 14, 2024 11:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant