Skip to content

small typo fixes while onboarding #1591

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged

small typo fixes while onboarding #1591

merged 1 commit into from
Dec 27, 2024

Conversation

GSmithApps
Copy link
Contributor

small typo fixes that I saw while onboarding and reading docs

@GSmithApps GSmithApps requested a review from a team as a code owner December 23, 2024 22:34
@GSmithApps
Copy link
Contributor Author

GSmithApps commented Dec 24, 2024

Thanks Spencer!

Should I go ahead and squash/merge? The button is green since Spencer approved. I read CONTRIBUTING.md and I don't see anything saying not to ✅

Thanks all! Plz let me know if there's something I should do differently to follow our procedures -- I'm just learning the ropes here 👍

@mjameswh
Copy link
Contributor

Hey @GSmithApps! Thanks for the fix.

Should I go ahead and squash/merge? The button is green since Spencer approved. I read CONTRIBUTING.md and I don't see anything saying not to ✅

Thanks all! Plz let me know if there's something I should do differently to follow our procedures -- I'm just learning the ropes here 👍

You did perfect, I'll take care of merging it.

Different teams have different preferences, but in case of doubts, it's always acceptable — and generally safer — to let the owner team actually merge PRs.

@mjameswh mjameswh merged commit 4cf092d into main Dec 27, 2024
23 checks passed
@mjameswh mjameswh deleted the grant-onboarding-typo-fix branch December 27, 2024 20:10
mjameswh pushed a commit that referenced this pull request Dec 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants