Skip to content

Commit

Permalink
Remove debug logger from visibility manager (#4751)
Browse files Browse the repository at this point in the history
<!-- Describe what has changed in this PR -->
**What changed?**
Remove debug logger from visibility manager.

<!-- Tell your future self why have you made these changes -->
**Why?**
It can print DB username and password.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**


<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No.
  • Loading branch information
rodrigozhou authored Aug 10, 2023
1 parent 2eb9609 commit 2da4743
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions common/persistence/visibility/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
"go.temporal.io/server/common/config"
"go.temporal.io/server/common/dynamicconfig"
"go.temporal.io/server/common/log"
"go.temporal.io/server/common/log/tag"
"go.temporal.io/server/common/metrics"
"go.temporal.io/server/common/persistence/sql/sqlplugin/mysql"
"go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql"
Expand Down Expand Up @@ -65,9 +64,6 @@ func NewManager(
metricsHandler metrics.Handler,
logger log.Logger,
) (manager.VisibilityManager, error) {
// Log configuration
logger.Info("loading new manager with the configuration: ", tag.Key("VisibilityStoreConfig"), tag.Value(persistenceCfg.GetVisibilityStoreConfig()))

visibilityManager, err := newVisibilityManagerFromDataStoreConfig(
persistenceCfg.GetVisibilityStoreConfig(),
persistenceResolver,
Expand Down

0 comments on commit 2da4743

Please # to comment.