-
Notifications
You must be signed in to change notification settings - Fork 877
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use explicit startup/shutdown order for development servers (#5459)
## What changed? Instead of starting all services in one process in parallel, serialize the startup in a defined order, and the shutdown in the reverse order. ## Why? This reduces noisy error logs during both startup and shutdown. I originally thought that serializing startup would be vulnerable to the problem fixed in #3100 but I couldn't reproduce it after a bunch of testing, so I think some other change in between must have also addressed that. If that problem reappears, though, an easy fix would be to start matching and history at the same time, and wait for them before moving on to frontend. ## How did you test it? local server startup/shutdown ## Potential risks Generally multiple services in one process is only used in development, so this shouldn't have any effect on production.
- Loading branch information
Showing
1 changed file
with
30 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters