Skip to content

Commit

Permalink
Do not double execute close execution task if visibility archival is …
Browse files Browse the repository at this point in the history
…disabled (#3072)
  • Loading branch information
yycptt authored and alexshtin committed Jul 8, 2022
1 parent 646f12d commit 56c5295
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions service/history/transferQueueStandbyProcessor.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,13 @@ func newTransferQueueStandbyProcessor(
case enumsspb.TASK_TYPE_TRANSFER_RESET_WORKFLOW:
// no reset needed for standby
return false
case enumsspb.TASK_TYPE_TRANSFER_CLOSE_EXECUTION,
enumsspb.TASK_TYPE_TRANSFER_DELETE_EXECUTION:
case enumsspb.TASK_TYPE_TRANSFER_DELETE_EXECUTION:
return true
case enumsspb.TASK_TYPE_TRANSFER_CLOSE_EXECUTION:
if shard.GetArchivalMetadata().GetVisibilityConfig().ClusterConfiguredForArchival() {
return true
}
fallthrough
default:
return taskAllocator.verifyStandbyTask(clusterName, namespace.ID(task.GetNamespaceID()), task)
}
Expand Down

0 comments on commit 56c5295

Please # to comment.