moving handler instantiation to allow noop reporter for autosetup (#2960

)
temporalio · Jun 7, 2022 · 81e7a13 · 81e7a13
1 parent b4f2ff5
commit 81e7a13
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/temporal/fx.go b/temporal/fx.go
@@ -180,15 +180,14 @@ func ServerOptionsProvider(opts []ServerOption) (serverOptionsProvider, error) {
 		clientFactoryProvider = client.NewFactoryProvider()
 	}
 
-	handler := metrics.MetricHandlerFromConfig(logger, so.config.Global.Metrics)
-
 	// ServerReporter
 	serverReporter := so.metricsReporter
 	if serverReporter == nil {
 		if so.config.Global.Metrics == nil {
 			logger.Warn("no metrics config provided, using noop reporter")
 			serverReporter = metrics.NoopReporter
 		} else {
+			handler := metrics.MetricHandlerFromConfig(logger, so.config.Global.Metrics)
 			serverReporter = metrics.NewEventsReporter(handler)
 		}
 	}