Properly handle min task ID > max task ID case during shard re-balanc…

…ing (#3470) * Properly handle min task ID > max task ID case by return unavailable error during shard re-balancing
temporalio · Oct 11, 2022 · d33559a · d33559a
1 parent 158737a
commit d33559a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/service/history/replication/ack_manager.go b/service/history/replication/ack_manager.go
@@ -267,7 +267,9 @@ func (p *ackMgrImpl) getTasks(
 	batchSize int,
 ) ([]*replicationspb.ReplicationTask, int64, error) {
 
-	if minTaskID == maxTaskID {
+	if minTaskID > maxTaskID {
+		return nil, 0, serviceerror.NewUnavailable("min task ID < max task ID, probably due to shard re-balancing")
+	} else if minTaskID == maxTaskID {
 		return []*replicationspb.ReplicationTask{}, maxTaskID, nil
 	}