Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Specific task queue partition name exposed in event history #4557

Closed
tsurdilo opened this issue Jun 28, 2023 · 0 comments · Fixed by #4565
Closed

Specific task queue partition name exposed in event history #4557

tsurdilo opened this issue Jun 28, 2023 · 0 comments · Fixed by #4565
Labels
potential-bug

Comments

@tsurdilo
Copy link
Contributor

In some cases service does not write the task queue name but the specific task queue partition into event history, for example:

    "taskQueue": {
       "name": "/_sys/myTaskQueueName/2",
       "kind": "Normal"
    },

Server team pointed to possible cause:

temporal/service/history/workflowTaskHandlerCallbacks.go

Lines 246 to 251 in f51b96d

_, workflowTask, err = mutableState.AddWorkflowTaskStartedEvent(
scheduledEventID,
requestID,
req.PollRequest.TaskQueue,
req.PollRequest.Identity,
)

and
https://github.com/temporalio/temporal/blob/f51b96d9248701dbb3f7c64bbb984404558b6d3c/service/history/workflow/workflow_task_state_machine.go#L4[…]67

Note this does not fail the workflow task, workers are still able to pick it up, but it is confusing when looking at event history and also user can think its a bug or issue with service
@dnr dnr mentioned this issue Jun 30, 2023
Merged
@dnr dnr closed this as completed in #4565 Aug 8, 2023
dnr added a commit that referenced this issue Aug 8, 2023
@dnr
Clean task queue name from matching before writing to WorkflowTaskSch…
e7dd2ff 
…eduledEvent (#4565)

**What changed?**
In some cases we write a new WorkflowTaskScheduledEvent right before a
WorkflowTaskStartedEvent in RecordWorkflowTaskStarted. In that case, the
task queue name comes from RecordWorkflowTaskStarted, but that name
comes from matching and may be a specific task queue partition, not the
base name. We should write only the base name.

**Why?**
Fixes #4557

**How did you test it?**
Unit test
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
potential-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean task queue name from matching before writing to WorkflowTaskScheduledEvent dnr/temporal
1 participant
@tsurdilo