Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use raw history/matching client in history task executor #4707

Closed
yycptt opened this issue Jul 31, 2023 · 0 comments
Closed

Use raw history/matching client in history task executor #4707

yycptt opened this issue Jul 31, 2023 · 0 comments
Assignees

Comments

@yycptt
Copy link
Member

yycptt commented Jul 31, 2023

History task processing framework already has it's own retry policy re. task processing failures. Using retryable history/matching client for talking to remote service when processing tasks are unnecessary and will cause tasks to retry while holding the goroutine.

This issue is most obvious when those client requests are getting rate limited, which is a retryable error and is retried slowly (backoff.ThrottledRetry) by the history/matching retryable client while holding the goroutine.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant