Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use raw history/matching client in task executor #4710

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Use raw history/matching client in task executor #4710

merged 3 commits into from
Aug 10, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jul 31, 2023

What changed?

  • Use raw history/matching client in task executor
  • NOTE: service handler will still perform retry but handler retry won't happen for resource exhausted errors, which is exactly what we need.

Why?

How did you test it?

  • Existing tests

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from a team as a code owner July 31, 2023 23:08
pdoerner
pdoerner approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@pdoerner pdoerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one quick question on transfer queue executors

@yycptt yycptt enabled auto-merge (squash) August 10, 2023 22:44
@yycptt yycptt merged commit 3a9e344 into temporalio:main Aug 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pdoerner pdoerner pdoerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @pdoerner