Use uuid as namespace notification ID #2733
Merged
+26
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Apr 19, 2022
dnr
reviewed
Apr 19, 2022
| @@ -323,7 +325,7 @@ func (e *historyEngineImpl) registerNamespaceFailoverCallback() { | |||
|
|
|||
| // first set the failover callback | |||
| e.shard.GetNamespaceRegistry().RegisterNamespaceChangeCallback( | |||
| e.shard.GetShardID(), | |||
| e.namespaceChangeListenerID, | |||
There was a problem hiding this comment.
you could use any instead of string and then use e itself here
meiliang86
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Use uuid as namespace change listener ID, instead of shard ID
yycptt
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Use uuid as namespace change listener ID, instead of shard ID
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
In case shard is reloaded
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A