Rename dt and di variables to workflowTask/wt #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jun 15, 2022
Comment on lines
9
to
12
| // in the Software without restriction, incluwtng without limitation the rights | ||
| // to use, copy, mowtfy, merge, publish, wtstribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // furnished to do so, subject to the following conwttions: |
There was a problem hiding this comment.
Oh.. I thought I always set "entire word" option.
| @@ -1778,7 +1778,7 @@ func (s *stateBuilderSuite) TestApplyEvents_EventTypeExternalWorkflowExecutionSi | |||
|
|
|||
| func (s *stateBuilderSuite) TestApplyEventsNewEventsNotHandled() { | |||
| eventTypes := enumspb.EventType_value | |||
| s.Equal(41, len(eventTypes), "If you see this error, you are adding new event type. "+ | |||
| s.Equal(41, len(eventTypes), "If you see this error, you are adwtng new event type. "+ | |||
There was a problem hiding this comment.
This is very cool test, btw.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Rename
dtanddivariables toworkflowTask/wt.Why?
Leftover from
decisionTasktoworkflowTaskrenames.How did you test it?
N/A
Potential risks
No risks.
Is hotfix candidate?
No.