Increase visibility RPS and burst dynamic configs for integration tests #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is just for test, could you overwrite the config value in the test? |
rodrigozhou
force-pushed
the
increase-default-namespace-rps-rate-limit
branch
from
79102b5 to
af40830
Compare
rodrigozhou
changed the title
yycptt
approved these changes
Oct 19, 2022
yycptt
reviewed
Oct 19, 2022
rodrigozhou
force-pushed
the
increase-default-namespace-rps-rate-limit
branch
from
af40830 to
c99a3de
Compare
rodrigozhou
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Increase value of
frontend.namespaceRPS.visibilityandfrontend.namespaceBurst.visibilityto 50 for integration tests.Why?
Integration tests
TestIntegrationSuite/Test_DeleteWorkflowExecution_*were failing with errornamespace rate limit exceeded, so I'm increasing the default limit.How did you test it?
Running integration tests locally consistently passed without rate limit exceeded error.
Potential risks
No.
Is hotfix candidate?
No.