Use safer default TIMESTAMP for MySQL. #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids compatibility issues with differing versions of MySQL. Using 24 hours after the minimum timestamp value allows for any timezone adjustment that MySQL would do to get a UTC value before storing. The timezone suffix is not supported by all current MySQL versions/derivatives. Fixes #119
yiminc
approved these changes
Oct 1, 2022
robholland
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Use a more widely compatible default timestamp for columns which require one on MySQL.
Why?
This avoids the timezone suffix syntax that is not supported by all MySQL versions/derivatives (MariaDB 10.6.8 on RDS being an example). Fixes #119 by being 24 hours after the minimum timestamp value, making it a valid value even if MySQL does a large timezone adjustment to UTC before storing.
How did you test it?
Used modified schema to
update-schemaon MariaDB.Potential risks
Any defaulted timestamps would have an unusual default which is not-quite-the-epoch. I don't think this is a problem.
Is hotfix candidate?
No.