Drop task on serialization error #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
force-pushed
the
drop-task-on-serialization-error
branch
from
43f676b to
414e188
Compare
yycptt
commented
Jan 12, 2023
Comment on lines
117
to
125
| DeserializationError struct { | ||
| msg string | ||
| encodingType enumspb.EncodingType | ||
| wrappedErr error | ||
| } | ||
|
|
||
| // UnknownEncodingTypeError is an error type for unknown or unsupported encoding type | ||
| UnknownEncodingTypeError struct { | ||
| encodingType enumspb.EncodingType | ||
| encodingTypeStr string | ||
| supportedEncodingStr []string |
There was a problem hiding this comment.
We should setup an alert to catch those error types returned from persistence client and the alert should fire whenever those errors occur. Otherwise some components may encounter those errors and retry slowly, which will never trigger the persistence error alert.
yycptt
commented
Jan 12, 2023
yiminc
reviewed
Jan 12, 2023
Comment on lines
117
to
125
| DeserializationError struct { | ||
| msg string | ||
| encodingType enumspb.EncodingType | ||
| wrappedErr error | ||
| } | ||
|
|
||
| // UnknownEncodingTypeError is an error type for unknown or unsupported encoding type | ||
| UnknownEncodingTypeError struct { | ||
| encodingType enumspb.EncodingType | ||
| encodingTypeStr string | ||
| supportedEncodingStr []string |
yycptt
force-pushed
the
drop-task-on-serialization-error
branch
from
649eb5c to
fea053e
Compare
yiminc
approved these changes
Jan 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?
Yes