Return nil instead of task discarded error if namespace is invalid locally #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Jul 25, 2023
wxing1292
added a commit
that referenced
this pull request
Jul 26, 2023
…cally (#4678) <!-- Describe what has changed in this PR --> **What changed?** * Return nil instead of task discarded error if namespace is invalid locally <!-- Tell your future self why have you made these changes --> **Why?** Returning task discarded error will make metrics confusing <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** N/A <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** N/A <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** N/A
wxing1292
added a commit
that referenced
this pull request
Jul 27, 2023
…cally (#4678) <!-- Describe what has changed in this PR --> **What changed?** * Return nil instead of task discarded error if namespace is invalid locally <!-- Tell your future self why have you made these changes --> **Why?** Returning task discarded error will make metrics confusing <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** N/A <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** N/A <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** N/A
rodrigozhou
pushed a commit
that referenced
this pull request
Aug 7, 2023
…cally (#4678) <!-- Describe what has changed in this PR --> **What changed?** * Return nil instead of task discarded error if namespace is invalid locally <!-- Tell your future self why have you made these changes --> **Why?** Returning task discarded error will make metrics confusing <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** N/A <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** N/A <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** N/A
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Returning task discarded error will make metrics confusing
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A