Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix tdbg unable to dump all workflow raw history issue #4681

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix tdbg unable to dump all workflow raw history issue #4681

merged 2 commits into from
Jul 25, 2023

Conversation

wxing1292
Copy link
Contributor

What changed?

  • Fix tdbg unable to dump all workflow raw history issue

Why?
Bugfix

How did you test it?
N/A

Potential risks
N/A

Is hotfix candidate?
N/A

@wxing1292 wxing1292 requested a review from a team as a code owner July 25, 2023 20:28
@wxing1292 wxing1292 enabled auto-merge (squash) July 25, 2023 20:29
yycptt
yycptt approved these changes Jul 25, 2023
View reviewed changes
tools/tdbg/commands.go
EndEventId: endEventId,
StartEventVersion: startEventVerion,
EndEventVersion: endEventVersion,
MaximumPageSize: 10000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮
will this timeout?

@wxing1292 wxing1292 merged commit 157bf67 into temporalio:master Jul 25, 2023
@wxing1292 wxing1292 deleted the cli branch July 25, 2023 21:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wxing1292 @yycptt