Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert version history bad request to internal error #4690

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jul 27, 2023

What changed?
Convert version history bad request to internal error

Why?
Bad request error will surface to users. This is the internal logic and if something is wrong, it should be internal error.

How did you test it?
unit tests

Potential risks

Is hotfix candidate?

@yux0 yux0 requested review from yycptt and wxing1292 July 27, 2023 05:59
@yux0 yux0 requested a review from a team as a code owner July 27, 2023 05:59
@yux0 yux0 merged commit 922cc27 into temporalio:master Jul 27, 2023
@yux0 yux0 deleted the vh-error branch July 27, 2023 16:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants