Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Log actual error for get history data loss events #4726

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Log actual error for get history data loss events #4726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions service/frontend/workflow_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2477,7 +2477,7 @@ func (wh *WorkflowHandler) CountWorkflowExecutions(ctx context.Context, request
}

resp := &workflowservice.CountWorkflowExecutionsResponse{
Count: persistenceResp.Count,
Count: persistenceResp.Count,
Groups: persistenceResp.Groups,
}
return resp, nil
Expand Down Expand Up @@ -4155,7 +4155,12 @@ func (wh *WorkflowHandler) getHistory(
// noop
case *serviceerror.DataLoss:
// log event
wh.logger.Error("encountered data loss event", tag.WorkflowNamespaceID(namespaceID.String()), tag.WorkflowID(execution.GetWorkflowId()), tag.WorkflowRunID(execution.GetRunId()))
wh.logger.Error("encountered data loss event",
tag.WorkflowNamespaceID(namespaceID.String()),
tag.WorkflowID(execution.GetWorkflowId()),
tag.WorkflowRunID(execution.GetRunId()),
tag.Error(err),
)
return nil, nil, err
default:
return nil, nil, err
Expand Down