Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable new schedule workflow logic #4741

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Enable new schedule workflow logic #4741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions service/worker/scheduler/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ var (
currentTweakablePolicies = tweakablePolicies{
DefaultCatchupWindow: 365 * 24 * time.Hour,
MinCatchupWindow: 10 * time.Second,
RetentionTime: 0, // TODO: enable later: 7 * 24 * time.Hour,
RetentionTime: 7 * 24 * time.Hour,
CanceledTerminatedCountAsFailures: false,
AlwaysAppendTimestamp: true,
FutureActionCount: 10,
Expand All @@ -191,8 +191,8 @@ var (
MaxBufferSize: 1000,
AllowZeroSleep: true,
ReuseTimer: true,
NextTimeCacheV2Size: 14, // see note below
Version: BatchAndCacheTimeQueries, // TODO: set later: NewCacheAndJitter
NextTimeCacheV2Size: 14, // see note below
Version: NewCacheAndJitter,
}

// Note on NextTimeCacheV2Size: This value must be > FutureActionCountForList. Each
Expand Down
6 changes: 0 additions & 6 deletions service/worker/scheduler/workflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,8 +1477,6 @@ func (s *workflowSuite) TestLotsOfIterations() {
}

func (s *workflowSuite) TestExitScheduleWorkflowWhenNoActions() {
s.T().Skip("re-enable later")

scheduleId := "myschedule"
s.expectStart(func(req *schedspb.StartWorkflowRequest) (*schedspb.StartWorkflowResponse, error) {
s.True(time.Date(2022, 6, 1, 0, 15, 0, 0, time.UTC).Equal(s.now()))
Expand Down Expand Up @@ -1525,8 +1523,6 @@ func (s *workflowSuite) TestExitScheduleWorkflowWhenNoActions() {
}

func (s *workflowSuite) TestExitScheduleWorkflowWhenNoNextTime() {
s.T().Skip("re-enable later")

scheduleId := "myschedule"
s.expectStart(func(req *schedspb.StartWorkflowRequest) (*schedspb.StartWorkflowResponse, error) {
s.True(time.Date(2022, 6, 1, 1, 0, 0, 0, time.UTC).Equal(s.now()))
Expand Down Expand Up @@ -1563,8 +1559,6 @@ func (s *workflowSuite) TestExitScheduleWorkflowWhenNoNextTime() {
}

func (s *workflowSuite) TestExitScheduleWorkflowWhenEmpty() {
s.T().Skip("re-enable later")

scheduleId := "myschedule"

currentTweakablePolicies.IterationsBeforeContinueAsNew = 3
Expand Down
2 changes: 0 additions & 2 deletions tests/schedule_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,8 +816,6 @@ func (s *scheduleIntegrationSuite) TestRateLimit() {
}

func (s *scheduleIntegrationSuite) TestNextTimeCache() {
s.T().Skip("re-enable after enabling new cache")

sid := "sched-test-next-time-cache"
wid := "sched-test-next-time-cache-wf"
wt := "sched-test-next-time-cache-wt"
Expand Down