Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve task range completion prerequisite check #4754

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Aug 9, 2023

What changed?

  • A follow up of Perform task range completion on shard rangeID update #4528 to make sure we won't call range completion with 0 (empty) exclusive max task key. Otherwise persistence layer will reject the request and cause queue processor to skip persisting its state.
  • ^ issue only happens in very care case (task processing doesn't make any progress for a new clsuter) and even if it happens there's no actual impact. Once the problem on the task processing side is fixed, the errors will be gone automatically.

Why?

  • see above

How did you test it?

  • Added unit test.

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from wxing1292 August 9, 2023 23:29
@yycptt yycptt requested a review from a team as a code owner August 9, 2023 23:29
@yycptt yycptt merged commit 5ced7bf into temporalio:main Aug 10, 2023
@yycptt yycptt deleted the fix-task-range-completion-check branch August 10, 2023 19:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants