Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix schedule workflow unit test #5052

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

dnr
Copy link
Member

@dnr dnr commented Oct 30, 2023

What changed?
Fix unit tests on release branch

Why?
The tests assumed that the change to not track ALLOW_ALL workflows was already active, but it's not on the release branch. So we just need mocks for WatchWorkflow.

How did you test it?
is tests

@dnr dnr requested a review from rodrigozhou October 30, 2023 23:33
@dnr dnr requested a review from a team as a code owner October 30, 2023 23:33
@rodrigozhou rodrigozhou force-pushed the release/v1.22.x branch 2 times, most recently from 7be9f85 to 2320fc1 Compare October 31, 2023 02:21
@dnr dnr force-pushed the fix-v1.22.2-test branch from b9cb556 to 9c0c3b9 Compare October 31, 2023 07:32
@dnr dnr merged commit ef3b92b into temporalio:release/v1.22.x Oct 31, 2023
4 checks passed
@dnr dnr deleted the fix-v1.22.2-test branch October 31, 2023 07:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant