Support TLS for elasticsearch #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tuyenpthust
force-pushed
the
tuyenpthust/elasticsearch-tls-support
branch
from
5d2a817 to
93d040a
Compare
common/persistence/visibility/store/elasticsearch/client/client_v7.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Deeb-Swihart <409226+tdeebswihart@users.noreply.github.com>
rodrigozhou
reviewed
Dec 1, 2023
rodrigozhou
reviewed
Dec 5, 2023
Co-authored-by: Rodrigo Zhou <rodrigozhou@users.noreply.github.com>
rodrigozhou
approved these changes
Dec 6, 2023
rodrigozhou
requested changes
Dec 6, 2023
rodrigozhou
approved these changes
Dec 6, 2023
|
@tuyenpthust what did you use to generate those test certificates? They just got expired and we need to generate new ones. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add config TLS for elasticsearch
Why?
Currently client connection to elasticsearch not support self-certificate TLS configuration
#3292
#3939
How did you test it?
Unit-test, local test
Potential risks
Is hotfix candidate?