Handle data corruption in history resend #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
commented
Feb 7, 2024
| tag.NewStringTag("first-resend-error", retryErr.Error()), | ||
| tag.NewStringTag("second-resend-error", resendErr.Error()), | ||
| ) | ||
| return false, serviceerror.NewDataLoss("failed to get requested data while resending history") |
There was a problem hiding this comment.
@yycptt any concern to use data loss error here?
meiliang86
approved these changes
Feb 8, 2024
yycptt
pushed a commit
that referenced
this pull request
Apr 27, 2024
Handle data corruption in history resend. 1. When source cluster has a data corruption issue, it can ship partial data in resend history. With the two layers of resending (this is to handle resend across different workflow runs), this will cause a chain reaction. Unit tests <!-- Assuming the worst case, what can be broken when deploying this change to production? --> <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Handle data corruption in history resend.
Why?
How did you test it?
Unit tests
Potential risks
Is hotfix candidate?