Allow completing a Nexus operation after workflow reset #6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
force-pushed
the
nexus-reset-started-operation
branch
from
e4c6628 to
28fcd8d
Compare
pdoerner
approved these changes
Aug 22, 2024
bergundy
force-pushed
the
nexus-reset-started-operation
branch
from
28fcd8d to
249df95
Compare
bergundy
force-pushed
the
nexus-reset-started-operation
branch
from
249df95 to
8e33880
Compare
lina-temporal
pushed a commit
that referenced
this pull request
Aug 30, 2024
## What changed? Added a request ID to the nexus completion token that can be used to check a completion against a state machine in a workflow post reset, e.g. with a new run ID. ## Why? Make reset safer. ## How did you test it? Added a functional test.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a request ID to the nexus completion token that can be used to check a completion against a state machine in a workflow post reset, e.g. with a new run ID.
Why?
Make reset safer.
How did you test it?
Added a functional test.