Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add target cluster to error messaging when verify replication tasks fails #6936

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Add target cluster to error messaging when verify replication tasks fails #6936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6a47dd
Add target cluster to error messaging
laniehei Dec 5, 2024
2f700a0
Merge branch 'main' into lanie/add-error-messaging-target-cluster
laniehei Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions service/worker/migration/activities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,10 +778,11 @@ func (a *activities) VerifyReplicationTasks(ctx context.Context, request *verify
if diff > defaultNoProgressNotRetryableTimeout {
// Potentially encountered a missing execution, return non-retryable error
return response, temporal.NewNonRetryableApplicationError(
fmt.Sprintf("verifyReplicationTasks was not able to make progress for more than %v minutes (not retryable). Not found WorkflowExecution: %v, Checkpoint: %v",
fmt.Sprintf("verifyReplicationTasks was not able to make progress for more than %v minutes (not retryable): could not find WorkflowExecution: '%v' in TargetCluster: '%s': Checkpoint: '%v', ",
diff.Minutes(),
details.LastNotVerifiedWorkflowExecution, details.CheckPoint),
"", nil)
details.LastNotVerifiedWorkflowExecution, request.TargetClusterName, details.CheckPoint),
"",
nil)
}
}
}
Loading