Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix error message #7352

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Fix error message #7352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/history/workflow/update/errors_failures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (

var (
registryClearedErr = errors.New("update registry was cleared")
workflowTaskFailErr = serviceerror.NewWorkflowNotReady("Unable to perform workflow execution update due unexpected workflow task failure.")
workflowTaskFailErr = serviceerror.NewWorkflowNotReady("Unable to perform workflow execution update due to unexpected workflow task failure.")
)

var (
Expand Down
4 changes: 2 additions & 2 deletions tests/update_workflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,7 +1330,7 @@ func (s *UpdateWorkflowSuite) TestUpdateWorkflow_ValidateWorkerMessages() {

var wfNotReady *serviceerror.WorkflowNotReady
s.ErrorAs(updateResult.err, &wfNotReady, "API caller should get serviceerror.WorkflowNotReady, if server got a validation error while processing worker response.")
s.Contains(updateResult.err.Error(), "Unable to perform workflow execution update due unexpected workflow task failure.")
s.Contains(updateResult.err.Error(), "Unable to perform workflow execution update due to unexpected workflow task failure.")
s.Nil(updateResult.response)
} else {
s.NoError(err)
Expand Down Expand Up @@ -2231,7 +2231,7 @@ func (s *UpdateWorkflowSuite) TestUpdateWorkflow_SpeculativeWorkflowTask_Fail()
updateResult := <-updateResultCh
var wfNotReady *serviceerror.WorkflowNotReady
s.ErrorAs(updateResult.err, &wfNotReady)
s.Contains(updateResult.err.Error(), "Unable to perform workflow execution update due unexpected workflow task failure.")
s.Contains(updateResult.err.Error(), "Unable to perform workflow execution update due to unexpected workflow task failure.")

// New transient WFT is created, but it is not shown in the history.
events := s.GetHistory(s.Namespace().String(), tv.WorkflowExecution())
Expand Down
Loading