test concurrent setCurrent/setRamping requests #7512
Conversation
| @@ -967,6 +936,37 @@ func (s *WorkerDeploymentSuite) TestSetWorkerDeploymentRampingVersion_NoCurrent_ | |||
| }) | |||
| } | |||
|
|
|||
| func (s *WorkerDeploymentSuite) TestSetCurrent_NoDeploymentVersion() { | |||
There was a problem hiding this comment.
just moved this test to an area which had all other setCurrent tests - no need to review this.
carlydf
changed the title
There was a problem hiding this comment.
Based on my understanding of the ticket, I think that these tests should not override the MaxInFlightUpdates -- we should test against the default because that's what customers will have. Ideally that will only cause throttling or timeout errors and nothing "weird." If any other error type comes up, that's a bug that should be addressed.
|
|
||
| for i := 0; i < versions; i++ { | ||
| err := <-errChan | ||
| s.NoError(err) |
There was a problem hiding this comment.
I think some of these requests might be expected to get throttling error or context timeout error. If you decrease the # of WorkflowExecutionMaxInFlightUpdates to the default (which is 10), do you see anything weird, or just throttling + timeout errors?
There was a problem hiding this comment.
I think instead of s.NoError you could keep the rest of this test the same, and just assert that the error is either:
- nil
- timeout
- throttling
There was a problem hiding this comment.
just bringing this up since the ticket said "confirm that concurrent updates with different inputs don't result in any weird errors, only throttling or timeout or success"
| @@ -1021,6 +1021,170 @@ func (s *WorkerDeploymentSuite) TestSetCurrentVersion_Unversioned_PromoteUnversi | |||
| s.verifyTaskQueueVersioningInfo(ctx, currentVars.TaskQueue(), worker_versioning.UnversionedVersionId, "", 0) | |||
| } | |||
|
|
|||
| func (s *WorkerDeploymentSuite) TestSetCurrentVersion_Concurrent_DifferentVersions() { | |||
| s.OverrideDynamicConfig(dynamicconfig.WorkflowExecutionMaxInFlightUpdates, 100) | |||
There was a problem hiding this comment.
I think this test should use the default value for this (which is 10). What do you think?
| } | ||
|
|
||
| func (s *WorkerDeploymentSuite) TestSetCurrentVersion_Concurrent_SameVersion() { | ||
| s.OverrideDynamicConfig(dynamicconfig.WorkflowExecutionMaxInFlightUpdates, 100) |
There was a problem hiding this comment.
same here, we should be testing this with default config
|
|
||
| for i := 0; i < 10; i++ { | ||
| err := <-errChan | ||
| s.NoError(err) |
There was a problem hiding this comment.
same here, throttling or timeout is acceptable
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?