Support pluggable config providers #102
Conversation
| } | ||
| ) | ||
|
|
||
| // NewServer returns a new instance of server that serves one or many services. | ||
| func NewServer(opts ...server_options.ServerOption) *Server { | ||
| serverOpts := server_options.NewServerOptions(opts) | ||
| cfgProvider, err := config.NewConfigProviderWithRefresh(*serverOpts.ConfigProvider) |
There was a problem hiding this comment.
This err is left unchecked, which may lead to cfgProvider being nil.
| return c.JSON(http.StatusInternalServerError, err) | ||
| } | ||
|
|
||
| tls, err := rpc.CreateTLSConfig(cfg.TemporalGRPCAddress, &cfg.TLS) |
There was a problem hiding this comment.
Is this called on every request and never cached?
There was a problem hiding this comment.
it's called on every request though receives a cached config https://github.com/temporalio/ui-server/pull/102/files#diff-0e504256c68c0d5b7cd3c799aa6c942469504ebb007e337f33cef429241061a1R67
There was a problem hiding this comment.
Config passed into rpc.CreateTLSConfig() is cashed, but the output of it is generated every time? And then rpc.CreateGRPCConnection() is also called every time. Shouldn't they be cached?
There was a problem hiding this comment.
right, figured to cache the GRPC connections once we add multi-connection support and work with the pool of connections. Can add caching now
server/routes/auth.go
Outdated
| ctx := context.Background() | ||
| cfg, _ := cfgProvider.GetConfig() |
feedmeapples
force-pushed
the
pluggable-config
branch
from
3bc3222
to
19035dc
Compare
feedmeapples
force-pushed
the
pluggable-config
branch
from
19035dc
to
3037dda
Compare
What was changed
Adds support for pluggable Config providers:
Why?
Flexibility in how the config is provided
TLS params periodic refresh
Checklist
Closes
How was this tested:
refreshInterval: 30s, ex in development.yaml filecaFile,certFile,keyFile,enableHostVerification,serverName2022[/02/16]() 11:38:06 loaded new UI server configurationin the logs, should also print that it loaded new TLS CA, KEY etc