Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove config provider interface pointer #106

Merged

Conversation

jlegrone
Copy link
Contributor

@jlegrone jlegrone commented Feb 25, 2022

What was changed

The WithConfigProvider start option has been updated to accept a ConfigProvider argument (an interface) rather than *ConfigProvider (a concrete type). This is a breaking change for users of the github.com/temporalio/ui-server/server/server_options package.

Why?

Pointers to interfaces can be tricky to work with; see this thread for more background: https://stackoverflow.com/questions/44370277/type-is-pointer-to-interface-not-interface-confusion

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples merged commit 2a22b72 into temporalio:main Feb 26, 2022
@jlegrone jlegrone deleted the jlegrone/config-provider-interface branch February 26, 2022 03:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants