Remove config provider interface pointer #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The
WithConfigProvider
start option has been updated to accept aConfigProvider
argument (an interface) rather than*ConfigProvider
(a concrete type). This is a breaking change for users of thegithub.heygears.com/temporalio/ui-server/server/server_options
package.Why?
Pointers to interfaces can be tricky to work with; see this thread for more background: https://stackoverflow.com/questions/44370277/type-is-pointer-to-interface-not-interface-confusion
Checklist
Closes
How was this tested: