Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix logout that didn't clear ID Token #182

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix logout that didn't clear ID Token #182

merged 1 commit into from
Jul 18, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Jul 18, 2022 •
edited
Loading

What was changed

  • Fixed logout that wouldn't clear ID Token cookie

Why?

  • Logout button wouldn't clear ID Token which would result in UI thinking the user is still logged in

Checklist

  1. Closes

  2. How was this tested:

  • Verified that logout button results in a Login page and both auth cookies are cleared
    image

  • WIP adding E2E test separately

  1. Any docs updates needed?

@feedmeapples feedmeapples merged commit 0e136f2 into main Jul 18, 2022
@feedmeapples feedmeapples deleted the clear-user branch July 18, 2022 16:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stevekinney stevekinney stevekinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feedmeapples @stevekinney