add resumable download file #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewzylu
reviewed
Jul 29, 2020
ut/test.py
Outdated
| @@ -1164,6 +1164,10 @@ def _test_get_object_sensitive_content_recognition(): | |||
| print(response) | |||
| assert response | |||
|
|
|||
| def test_download_file(): | |||
| """测试断点续传下载接口""" | |||
| client.download_file(test_bucket, test_object, 'test_download_file.local') | |||
lewzylu
requested changes
Jul 29, 2020
qcloud_cos/cos_client.py
Outdated
| @@ -2942,6 +2943,30 @@ def _check_all_upload_parts(self, bucket, key, uploadid, local_path, parts_num, | |||
| already_exist_parts[part_num] = part['ETag'] | |||
| return True | |||
|
|
|||
| def download_file(self, Bucket, Key, DestFilePath, PartSize=20, MAZThread=5, EnableCRC=False, **Kwargs): | |||
| """小于等于20MB的文件简单上传，大于20MB的文件使用分块上传 | |||
dt3310321
reviewed
Aug 3, 2020
qcloud_cos/cos_client.py
Outdated
| :param key(string): 分块上传路径名. | ||
| :param LocalFilePath(string): 本地文件路径名. | ||
| :param PartSize(int): 分块的大小设置,单位为MB. | ||
| :param MAXThread(int): 并发上传的最大线程数. |
dt3310321
reviewed
Aug 3, 2020
qcloud_cos/resumable_downloader.py
Outdated
| pool.wait_completion() | ||
| result = pool.get_result() | ||
| if not result['success_all']: | ||
| raise CosClientError('some upload_part fail after max_retry, please upload_file again') |
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.