-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix genesis functionality after F1 adoption #112
Conversation
also rename `global_last_epoch_time` to `last_epoch_time`
also call SetGlobalPlanId once for the last plan in the records
this reduces decimal error when calculating outstanding rewards
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 66.01% 66.36% +0.34%
==========================================
Files 24 24
Lines 2107 2224 +117
==========================================
+ Hits 1391 1476 +85
- Misses 580 608 +28
- Partials 136 140 +4
Continue to review full report at Codecov.
|
It still needs more test codes |
Could you check this comment #115 (review) and apply also this issue and PR? and need to resolve some conflicts |
Description
closes: #104
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes