Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix genesis functionality after F1 adoption #112

Merged
merged 12 commits into from
Sep 16, 2021

Conversation

hallazzang
Copy link
Contributor

Description

closes: #104


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang added the bug Something isn't working label Sep 15, 2021
@hallazzang hallazzang added this to the Farming F1 MVP milestone Sep 15, 2021
@hallazzang hallazzang self-assigned this Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #112 (1e7124f) into master (9d7cd9c) will increase coverage by 0.34%.
The diff coverage is 82.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   66.01%   66.36%   +0.34%     
==========================================
  Files          24       24              
  Lines        2107     2224     +117     
==========================================
+ Hits         1391     1476      +85     
- Misses        580      608      +28     
- Partials      136      140       +4     
Impacted Files Coverage Δ
x/farming/abci.go 0.00% <0.00%> (ø)
x/farming/types/keys.go 0.00% <0.00%> (ø)
x/farming/keeper/genesis.go 79.46% <84.09%> (+3.14%) ⬆️
x/farming/keeper/reward.go 88.26% <86.20%> (+0.68%) ⬆️
x/farming/keeper/staking.go 90.90% <90.00%> (+0.43%) ⬆️
x/farming/types/genesis.go 52.63% <100.00%> (+3.50%) ⬆️
x/farming/types/msgs.go 68.42% <0.00%> (-7.07%) ⬇️
x/farming/keeper/keeper.go 75.00% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d7cd9c...1e7124f. Read the comment docs.

@hallazzang
Copy link
Contributor Author

It still needs more test codes

@hallazzang hallazzang requested a review from dongsam September 16, 2021 09:02
@dongsam
Copy link
Contributor

dongsam commented Sep 16, 2021

Could you check this comment #115 (review) and apply also this issue and PR? and need to resolve some conflicts

@dongsam dongsam marked this pull request as ready for review September 16, 2021 10:11
@dongsam dongsam merged commit 1e6f946 into tendermint:master Sep 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing genesis functionality after F1 adoption
2 participants