fix: app version text bug

[Zfinix]

This fixes an import bug where AppVersionText is imported from two locations, package:cosmos_ui_components/components/app_version_text.dart was preferred in this instance.

[wal33d006]

Why do we have updated pubspec.lock files for all the packages?

[Zfinix]

I guess it’s not getting git ignored

On Wed, 13 Apr 2022 at 6:06 AM, Waleed Arshad ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/cosmos_auth/pubspec.lock <#254 (comment)>: > @@ -97,7 +97,7 @@ packages: description: path: "packages/cosmos_utils" ref: main - resolved-ref: "6d6a66c11aec98326728f99eab2672a88a9de8a3" + resolved-ref: "7e2bb662a74772ada30870e605ce3aeae6dfb3cb" Why do we have updated pubspec.lock files for all the packages? — Reply to this email directly, view it on GitHub <#254 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGE3JSK3JEVSKBOUC2KMDJ3VEZI4DANCNFSM5TJHYUFA> . You are receiving this because you were assigned.Message ID: ***@***.***>

-- Chiziaruhoma O.

[wal33d006]

The last I remember, it doesn't get git ignored. I think this is happening because pub upgrade might have been run in each of these libraries, can you try reverting the lock files for all except for the template?

[Zfinix]

Sure

On Wed, 13 Apr 2022 at 1:36 PM, Waleed Arshad ***@***.***> wrote: The last I remember, it doesn't get git ignored. I think this is happening because pub upgrade might have been run in each of these libraries, can you try reverting the lock files for all except for the template? — Reply to this email directly, view it on GitHub <#254 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGE3JSKFDKAI2MWHAXNNW7LVE25WDANCNFSM5TJHYUFA> . You are receiving this because you were assigned.Message ID: ***@***.***>

-- Chiziaruhoma O.

[Zfinix]

The last I remember, it doesn't get git ignored. I think this is happening because pub upgrade might have been run in each of these libraries, can you try reverting the lock files for all except for the template?

I don't see how updating the pub versions are a bad idea as we depend on the latest versions of these packages...

[wal33d006]

The pub versions aren't a bad idea, it's this thing that we don't change things in multiple packages at once, since these packages are being consumed itself by the template, we usually FIRST change things in the packages with a separate PR and then we change the consumers of these packages just to make sure the code within the packages and inside the consumers is good with the latest versions
@andrzejchm What do you say about this?

[Zfinix]

The pub versions aren't a bad idea, it's this thing that we don't change things in multiple packages at once, since these packages are being consumed itself by the template, we usually FIRST change things in the packages with a separate PR and then we change the consumers of these packages just to make sure the code within the packages and inside the consumers is good with the latest versions @andrzejchm What do you say about this?

But i believe that if these refs are updated using pub update it means that they have been merged into our main branch hence no conflict can occur

[wal33d006]

Exactly my point, the changes should not be shown if they have been already in main

[andrzejchm]

the problem with pubspec.lock changing so often and in multiple packages is because of the fact that all packages lay down in the same repo, so as soon as we change anything anywhere in the repo, running pub get in all the packages will cause the change of the commit ref in pubspec.lock. This is actually fine to always update it in all packages as part f the pr, because if it would break anything, then a build would not pass on the CI. this will no longer be an issue as soon as we switch to separate repos for every package

[Zfinix]

Moved PR to #258