fix(campaign): fix sample genesis with inconsistent state
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
fadeev,
ilgooz,
Pantani,
ivanovpetr,
aljo242 and
giunatale
as code owners
giunatale
approved these changes
Apr 4, 2022
Codecov Report
@@ Coverage Diff @@
## develop #684 +/- ##
===========================================
- Coverage 10.92% 10.91% -0.01%
===========================================
Files 274 274
Lines 60446 60446
===========================================
- Hits 6601 6595 -6
- Misses 53644 53648 +4
- Partials 201 203 +2
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CampaignGenesisStatefromsamplecontains campaigns initialized with empty allocated shares and mainnet accounts containing shares.This genesis state was inconsistent because the sum of shares allocated for accounts must be tracked by the
AllocatedSharesvalue of the campaignThis PR removes the accounts for a quick fix. A further change can include adding accounts with the allocated correctly tracked for better entropy