Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: push docker image also to Github registry #605

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tobiasdiez
Copy link

Currently the docker image is only pushed to the Docker Hub repository. In certain countries dockerhub is not working very reliable, thus this PR proposes to also publish the images to the Github Packages repository.

The code is essentially taken from the cloudnative variant: https://github.com/tensorchord/cloudnative-pgvecto.rs/blob/main/.github/workflows/docker.yml

Test run currently fails already at the build step, so I don't know how to test this: https://github.com/tobiasdiez/pgvecto.rs/actions/runs/11326123877/job/31494425115

@gaocegege
Copy link
Member

LGTM

Thanks for your contribution! 🎉 👍

cc @VoVAllen

@usamoi
Copy link
Collaborator

usamoi commented Oct 15, 2024

Test run currently fails already at the build step

Should be fixed now.

@tobiasdiez
Copy link
Author

Test run currently fails already at the build step

Should be fixed now.

Thanks! I've rerun the workflow, but it's now failing because I (obviously) don't have the correct docker hub credentials: https://github.com/tobiasdiez/pgvecto.rs/actions/runs/11426048592/job/31788570283

So I have no idea how to properly test these changes. Sorry.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants