Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

release: v0.4.0 #615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cutecutecat
Copy link
Member

@cutecutecat cutecutecat commented Nov 19, 2024

Breaking change

The update from 0.3.0 to 0.4.0 might fail!

Due to a conflict definition of _vectors_svecf32_in at 0.3.0:

_vectors_svecf32_in(input, oid, _typmod)

and at 0.2.1--0.3.0:

_vectors_svecf32_in(input, oid, typmod)

As 0.4.0 picks latter signature, and PostgreSQL doesn't support parameter name changing.

Therefore the update route of 0.2.1 -> 0.3.0 -> 0.4.0 can succeed, but 0.3.0 -> 0.4.0 would fail.

Ref: L744 of file sql/upgrade/vectors--0.3.0--0.4.0.sql

Signed-off-by: cutecutecat <junyuchen@tensorchord.ai>
@usamoi
Copy link
Collaborator

usamoi commented Nov 20, 2024

Due to a conflict definition of _vectors_svecf32_in at 0.3.0:

Why? I cannot see.

CREATE FUNCTION "_vectors_svecf32_in"(
"input" cstring, /* &core::ffi::c_str::CStr */
"_oid" oid, /* pgrx_pg_sys::submodules::oids::Oid */
"typmod" INT /* i32 */
) RETURNS svector /* vectors::datatype::memory_svecf32::SVecf32Output */
IMMUTABLE STRICT PARALLEL SAFE
LANGUAGE c /* Rust */
AS 'MODULE_PATHNAME', '_vectors_svecf32_in_wrapper';
. The parameter name is typmod.

CREATE FUNCTION "_vectors_svecf32_in"(
"input" cstring,
"_oid" oid,
"typmod" INT
) RETURNS svector
IMMUTABLE STRICT PARALLEL SAFE LANGUAGE c AS 'MODULE_PATHNAME', '_vectors_svecf32_in_wrapper';
. The parameter name is typmod.

@@ -859,7 +859,7 @@ AS 'MODULE_PATHNAME', '_vectors_svecf32_norm_wrapper';
CREATE FUNCTION "_vectors_svecf32_in"(
"input" cstring, /* &core::ffi::c_str::CStr */
"_oid" oid, /* pgrx_pg_sys::submodules::oids::Oid */
"typmod" INT /* i32 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strictly forbidden to edit historic schema scripts.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants