Exposed the pure python implementation of mish and softshrink. #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are owner of some files modified in this pull request. |
gabrieldemarmiesse
changed the title
seanpmorgan
approved these changes
Mar 9, 2020
| from tensorflow_addons.utils import test_utils | ||
|
|
||
|
|
||
| @test_utils.run_all_in_graph_and_eager_modes | ||
| class SoftshrinkTest(tf.test.TestCase, parameterized.TestCase): | ||
| def test_invalid(self): | ||
| with self.assertRaisesOpError("lower must be less than or equal to upper."): | ||
| y = softshrink(tf.ones(shape=(1, 2, 3)), lower=2.0, upper=-2.0) | ||
| y = _softshrink_custom_op(tf.ones(shape=(1, 2, 3)), lower=2.0, upper=-2.0) |
There was a problem hiding this comment.
What's preventing this from being configurable so we can test custom and not custom? The regex for error?
Not blocking this PR but something we might want to aim for being able to do.
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
…rflow#1252) * Exposed the pure python implementation of mish. * Exposed the pure implementation of softshrink publicly. * Fix name. * The same error is not raise in python and in the custom op.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.