Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update dense_image_warp.py #2468

Closed
wants to merge 1 commit into from
Closed

Conversation

alisaaalehi
Copy link

By simply negating the flow vectors we will not get the same result as warping based on optical flow.
Your test cases might be too simple to capture this issue.

Description

Brief Description of the PR:

Fixes # (issue)

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

By simply negating the flow vectors we will not get the same result as warping based on optical flow.
Your test cases might be too simple to capture this issue.
@alisaaalehi alisaaalehi requested a review from WindQAQ as a code owner May 4, 2021 22:46
@boring-cyborg boring-cyborg bot added the image label May 4, 2021
@google-cla google-cla bot added the cla: yes label May 4, 2021
@bhack
Copy link
Contributor

bhack commented May 10, 2022

Thank you for your contribution.
It is better that you help to port and expand this in Keras-cv:
keras-team/keras-cv#163

@bhack bhack closed this May 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants