Failing to restore AdaBelief optimizer from checkpoint #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are owner of some files modified in this pull request. |
denadai2
changed the title
bhack
requested changes
May 18, 2022
There was a problem hiding this comment.
You need to add the checkpoint test here as in:
https://github.com/tensorflow/addons/pull/2369/files
bhack
approved these changes
May 18, 2022
|
Thanks @bhack! When do you think it will be possible to have a release of tensorflow addons so that it is possible to have AdaBelief in production? The nightly version might not be accepted in my company :) thx |
|
You can subscribe to #2696 |
|
LGTM, thanks for fixing the problem. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
This PR solves the same issue reported in #2361, by avoiding storing a int32 variable.
Type of change
Checklist: